Skip to content

Conversation

@akshya96
Copy link
Contributor

@akshya96 akshya96 commented Dec 3, 2025

Description

What does this PR do?
No additional keys for license config is present in ce. This fixes testing.go which creates a test cluster for unit tests.
The additional keys are []interface{} in ce and []ed25519.PublicKey in ent.

Original PR: https://github.com/hashicorp/vault-enterprise/pull/10701
Ent PR: Fix adding additional public keys for tests in ent
Ent PR second fix: https://github.com/hashicorp/vault-enterprise/pull/11114

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • Jira: If this change has an associated Jira, it's referenced either in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.

Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@akshya96 akshya96 requested a review from a team as a code owner December 3, 2025 19:19
@akshya96 akshya96 requested a review from stuti-sr December 3, 2025 19:19
@vercel
Copy link

vercel bot commented Dec 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
vault-ui Ready Ready Preview Comment Dec 3, 2025 10:43pm

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Dec 3, 2025
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

CI Results: failed ❌

@akshya96
Copy link
Contributor Author

akshya96 commented Dec 3, 2025

Will merge backport from ENT.

@akshya96 akshya96 closed this Dec 3, 2025
auto-merge was automatically disabled December 3, 2025 23:49

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants