Fix brace-depth parsing in wifi_draw_message nonblocking test#568
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix code based on review comments
Fix non-blocking WiFi status screens and harden the regression guard
Jun 4, 2026
Owner
|
@copilot resolve the merge conflicts in this pull request |
…review-comments # Conflicts: # tests/test_wifi_scan_status_nonblocking.c
Author
hapaxx11
approved these changes
Jun 4, 2026
There was a problem hiding this comment.
Pull request overview
This PR hardens the WiFi “transient status must be non-blocking” regression guard to prevent future reintroduction of stalls on pre-action screens like “Scanning APs…” / “Connecting…” by tightening how the test locates wifi_draw_message() and expanding positive assertions for additional WiFi flows.
Changes:
- Update the
wifi_draw_message()body extraction logic in the regression test to be anchored to a closing brace instead of the nextstaticsymbol. - Strengthen regression assertions so Wardrive and Save APs pre-scan statuses must also use
wifi_draw_message(). - Minor formatting cleanup in the tests CMake file (trailing/blank line adjustment).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/test_wifi_scan_status_nonblocking.c | Tightens source-level regression checks to ensure transient WiFi scan/connect status screens remain non-blocking across multiple flows. |
| tests/CMakeLists.txt | Minor formatting cleanup (no functional test registration changes). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Copilot
AI
changed the title
Fix non-blocking WiFi status screens and harden the regression guard
Fix brace-depth parsing in wifi_draw_message nonblocking test
Jun 4, 2026
hapaxx11
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
strstr(fn, "\n}")to locate the end ofwifi_draw_message()is fragile — any}at column 0 inside nested blocks or#ifsections truncates the extracted body early, causingwifi_wait_dismisschecks to silently pass on incomplete text.Changes
tests/test_wifi_scan_status_nonblocking.c— Replacestrstr(fn, "\n}")with a brace-depth walk from the function's opening{, stopping when depth returns to zero. This correctly handles nested blocks regardless of brace column position..changelog/wifi-draw-message-nonblocking-test.fixed.md— Changelog fragment for this fix.