Skip to content

Conversation

@Frozen
Copy link
Collaborator

@Frozen Frozen commented Nov 17, 2023

@sophoah
Copy link
Contributor

sophoah commented Nov 22, 2023

@Frozen i think that one is good. Can you add two tests dealing with a network that has HIP30 epoch defined as TBD, and another one set with a fixed number. First one should use the default / genesis sharding config while the other one should use the sharding config of HIP30.

Things to note, at the end what we want is to know the latest sharding configuration (4 shard vs 2 shards) when we start the node from height 0, be it with HIP30 or with future HIP, so maybe we could define a function that does just that.

@diego1q2w @GheisMohammadi feel free to chime in any other ideas.

@Frozen Frozen self-assigned this Jun 13, 2024
@sophoah
Copy link
Contributor

sophoah commented Jan 29, 2025

@Frozen not sure why but something weird here. I was working on testing that PR and

numShards := conf.shardingSchedule.InstanceForEpoch(epoch).NumShards()

always give me numShards = 2 whether I use HIP30Epoch or stakingEpoch in epoch := conf.networkType.ChainConfig().StakingEpoch

Can you double confirm ?

@sophoah
Copy link
Contributor

sophoah commented Jan 29, 2025

nevermind I found the issue

@sophoah sophoah marked this pull request as ready for review January 29, 2025 10:07
@sophoah sophoah force-pushed the fix/shard-id-from-key branch from 121f125 to f8b7bfb Compare January 30, 2025 03:20
@sophoah sophoah merged commit e65ceec into dev Jan 30, 2025
4 checks passed
@sophoah sophoah deleted the fix/shard-id-from-key branch January 30, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants