Block proposing moved from Node to Consensus. #4698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Frozen
commented
Jun 21, 2024
- Block proposing uses 99% consensus and 1% node code, but it is located within the node.
- The chained protocol requires block proposing from consensus, causing a circular dependency error.
adsorptionenthalpy
approved these changes
Jun 22, 2024
sophoah
reviewed
Jun 24, 2024
| func GetPendingCXKey(shardID uint32, blockNum uint64) string { | ||
| key := strconv.FormatUint(uint64(shardID), 10) + "-" + strconv.FormatUint(blockNum, 10) | ||
| return key | ||
| func GetPendingCXKey(shardID uint32, blockNum uint64) CXKey { |
Contributor
There was a problem hiding this comment.
can the difference of key format returned cause any issue in our codebase calling that function ?
Collaborator
Author
There was a problem hiding this comment.
Cache keeped only in the memory, so, restart will erase everything.
Exactly in this case, we have 4 memory allocations for no reason. My version has no allocations.
ONECasey
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.