View change: Support for checking if validators belongs to the same key. #4802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophoah
reviewed
Nov 21, 2024
sophoah
reviewed
Nov 21, 2024
sophoah
reviewed
Nov 21, 2024
sophoah
reviewed
Nov 21, 2024
sophoah
reviewed
Nov 22, 2024
Contributor
|
@Frozen can you help rebase and fix conflict here. |
ba7d2a5 to
37e81e1
Compare
Contributor
|
@Frozen can you rebase this one with the latest dev ? |
Contributor
|
@Frozen I tested killing the external validator node to test view change in two scenarios: make multi-bls-key and make-multi-bls-key-multi-extl-node (#4819) Both fails to even recover from view change. Networks is basically down when view change kick off when the external leader fails to propose for the test cc @mur-me |
Contributor
|
@Frozen can you rebase with latest dev and fix any conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for checking if validators belongs to the same key.
Leader Rotation based on
getLeaderPubKeywhich is different for each iteration, while the view change it stays the same all time, that's why it requires additional actions for leader selection.Based on feature
IsLeaderRotationV2Epochapplies methodgetNextLeaderKeySkipSameAddress.