Refactor Staged Stream Sync Downloader Loop, Remove Sync Overlaps #4861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophoah
approved these changes
Feb 28, 2025
Contributor
sunwavesun
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the staged stream sync downloader's sync loop to enhance concurrency, remove sync overlaps caused by multiple downloader triggering. To remove the sync overlaps, if the node is syncing and the ticker fires, the trigger will attempt to queue another sync, but only if no sync is already in progress. But, if a sync is running, the trigger does nothing at that moment, avoiding unnecessary sync overlap.