Optimize and Clean-Up Stages in Staged Stream Sync, Thread Safe P2P Stream #4891
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the reliability and clarity of the sync process. The P2P stream is now thread-safe and resets automatically on failure, which helps prevent sync hangs. Short range sync was updated to accept partial blocks and properly break the loop when done, improving flexibility and performance during catch-up.
Several refactors and clean-ups were made to staged sync: initSync now uses internal parameters instead of external variables, and the unused LogProgress option was removed. We also fixed DB path handling for stream sync and re-added last mile blocks to ensure full chain coverage.
On the beacon side, we cleaned up redundant shard checks, fixed beacon helper initialization, and clarified internal comments. Minor improvements include fixing stream failure type handling and simplifying epoch tracking with a dedicated variable.