Fix Galaga fire edge detection and menu return#81
Open
sisraelson-home wants to merge 1 commit into
Open
Conversation
Galaga: the Namco 06xx 3-byte polling cycle read buttons and updated prev_mask on every byte, so fire/coin/start edges were frequently consumed on byte 0 (credit byte) before the byte that encodes them. Sample buttons once at namco_cnt==0 and latch the fire edge for the whole cycle so byte 1 always reports it reliably. buttons_get: the BUTTON_EXTRA detection was wrapped in nested #ifndef/#ifdef BTN_COIN_PIN, making the inner branch dead code and leaving BUTTON_EXTRA unset whenever BTN_COIN_PIN was defined. Restored the intended behavior (coin pin when present, start pin otherwise) and raised the hold threshold to 3 seconds to avoid accidental resets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Galaga: the Namco 06xx 3-byte polling cycle read buttons and updated prev_mask on every byte, so fire/coin/start edges were frequently consumed on byte 0 (credit byte) before the byte that encodes them. Sample buttons once at namco_cnt==0 and latch the fire edge for the whole cycle so byte 1 always reports it reliably.
buttons_get: the BUTTON_EXTRA detection was wrapped in nested #ifndef/#ifdef BTN_COIN_PIN, making the inner branch dead code and leaving BUTTON_EXTRA unset whenever BTN_COIN_PIN was defined. Restored the intended behavior (coin pin when present, start pin otherwise) and raised the hold threshold to 3 seconds to avoid accidental resets.