Extended serialization for cron fields #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions object instead of a wildcard argument
…ely on CronDayOfWeek exposed state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves several aspects of expression serialization:
nth-day(#) serialization?in serialized cron expressionsIt also includes some minor BREAKING CHANGES:
CronFieldconstructor signature has changed. Instead of thewildcardboolean argument, it now takes a full-fledgedCronFieldOptionsobject.nthDayOfWeekoption (which was undocumented or inconsistently used) has been removed fromCronExpressionOptions.These changes shouldn't affect most users, but caution is advised when working directly with
CronField-related APIs.Fixes #358 and #349