feat: Support more natural languages for the features. #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdipax
commented
Jun 16, 2024
wdipax
commented
Jun 16, 2024
wdipax
commented
Jun 16, 2024
Contributor
Author
wdipax
left a comment
There was a problem hiding this comment.
More questions for discussion.
internal/generator/examples/default/simple.en-pirate.feature_test.go
Outdated
Show resolved
Hide resolved
wdipax
commented
Jun 16, 2024
internal/generator/examples/default/simple.en-pirate.feature.json
Outdated
Show resolved
Hide resolved
wdipax
commented
Jun 17, 2024
Contributor
Author
wdipax
left a comment
There was a problem hiding this comment.
More explicit naming.
Owner
|
thank you, I will check later today! |
hedhyw
previously approved these changes
Jun 17, 2024
internal/generator/examples/default/simple.en-pirate.feature.json
Outdated
Show resolved
Hide resolved
internal/generator/examples/default/simple.en-pirate.feature_test.go
Outdated
Show resolved
Hide resolved
Owner
|
@wdipax Let's merge Also, try to run Thanks! |
More explicit naming.
More explicit naming.
9df5a2b to
ef24c9f
Compare
added 2 commits
June 20, 2024 14:05
hedhyw
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now feature descriptions are only supported in English. The Gherkin framework supports many more natural languages.
This pull request adds support for features written in all natural languages supported by Gherkin.