feat(docker): Bump dependencies in Dockerfile #620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch bumps the versions of pip, kubectl, helm, and yamllint. Signed-off-by: Fabian Meyer <3982806+meyfa@users.noreply.github.com>
cpanato
requested changes
Jan 8, 2024
|
|
||
| # Install a YAML Linter | ||
| ARG yamllint_version=1.29.0 | ||
| ARG yamllint_version=1.33.0 |
Member
There was a problem hiding this comment.
there is any breaking changes that migth affect the users?
Contributor
Author
There was a problem hiding this comment.
As far as I can tell, no. Relevant updates:
- one new rule (should be irrelevant unless users configure this, so not breaking)
- new rule options (also not breaking)
- fixed false-positives (meaning less errors, therefore not breaking)
Ref: https://github.com/adrienverge/yamllint/blob/master/CHANGELOG.rst
cpanato
approved these changes
Jan 19, 2024
Contributor
Author
|
@cpanato Thanks for the review & merging! Is there any timeline for a new release? |
Member
|
@meyfa trying, need to find a bit more time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This patch bumps the versions of pip, kubectl, helm, and yamllint.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
I have run build.sh locally to verify it still builds, and all the tools are present and working at the proper versions when running the image with Docker.