Skip to content

fix(doc): fix kube client interface doc. #9882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2021
Merged

fix(doc): fix kube client interface doc. #9882

merged 1 commit into from
Jul 6, 2021

Conversation

@longkai
Copy link
Contributor

@longkai longkai commented Jun 28, 2021 •
edited
Loading

For the interface at pkg/kube/interface.go:

  • add missing interface methods doc.
  • fix some wrong english grammar.

What this PR does / why we need it:

Fix kube client interface doc.

If applicable:

  • this PR has been tested for backwards compatibility

@longkai
fix(doc): fix kube client interface doc.
615a1f3 
- add missing interface methods doc.
- fix some wrong english grammar.

Signed-off-by: longkai <im.longkai@gmail.com>
@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 28, 2021
@mattfarina mattfarina added this to the 3.6.3 milestone Jul 1, 2021
@mattfarina
Copy link
Collaborator

mattfarina commented Jul 1, 2021

Note, this requires the approval of a second maintainer before merging.

technosophos
technosophos approved these changes Jul 6, 2021
View reviewed changes
Copy link
Member

@technosophos technosophos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technosophos technosophos merged commit cf0c6fe into helm:main Jul 6, 2021
@mattfarina mattfarina added needs-pick Indicates that a PR needs to be cherry-picked into the next release candidate. picked Indicates that a PR has been cherry-picked into the next release candidate. labels Jul 14, 2021
mattfarina pushed a commit that referenced this pull request Jul 14, 2021
@longkai @mattfarina
fix(doc): fix kube client interface doc. (#9882)
29d4e1b 
- add missing interface methods doc.
- fix some wrong english grammar.

Signed-off-by: longkai <im.longkai@gmail.com>
(cherry picked from commit cf0c6fe)
tylerauerbeck pushed a commit to tylerauerbeck/helm that referenced this pull request Aug 5, 2021
@longkai @tylerauerbeck
fix(doc): fix kube client interface doc. (helm#9882)
7f805ed 
- add missing interface methods doc.
- fix some wrong english grammar.

Signed-off-by: longkai <im.longkai@gmail.com>
zak905 pushed a commit to zak905/helm that referenced this pull request Jan 19, 2023
@longkai @zak905
fix(doc): fix kube client interface doc. (helm#9882)
39791f3 
- add missing interface methods doc.
- fix some wrong english grammar.

Signed-off-by: longkai <im.longkai@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattfarina mattfarina mattfarina approved these changes

@technosophos technosophos technosophos approved these changes

+1 more reviewer

@cndoit18 cndoit18 cndoit18 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-pick Indicates that a PR needs to be cherry-picked into the next release candidate. picked Indicates that a PR has been cherry-picked into the next release candidate. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

3.6.3

Development

Successfully merging this pull request may close these issues.

5 participants

@longkai @mattfarina @technosophos @cndoit18 @helm-bot