feat: add functions#6
Conversation
|
@rirze Thank you for the contribution! At first glance this looks really good.-- I'll do a deeper review later today and get back to you. |
|
@rirze Looks great. Unfortunately it seems Pygments doesn't support provider-defined function calls. Can you remove the I've filed a PR with them to add support: pygments/pygments#2915 |
|
|
||
| Once implemented, your functions can be used in Terraform configurations: | ||
|
|
||
| ```hcl |
There was a problem hiding this comment.
Remove this hcl language specifier for now
| # Using provider functions | ||
| output "example" { | ||
| value = provider::myprovider::myfunction("input") | ||
| } |
There was a problem hiding this comment.
Can you break these four lines out into it's triple-tick own block? That way we can keep the hiliting for the stuff above it.
|
I tried to fix the highlighting issues you noted and I updated the pyproject.toml to a more compatible standard. If you prefer I don't add those changes, I can revert that commit. Let me know! |
|
Looks great! Thank you again for the excellent quality contribution! |
No description provided.