This repository was archived by the owner on Dec 1, 2024. It is now read-only.
Separate SingleRuleLinter into Linter and LintRule #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5bec5e5 to
5f2c53f
Compare
c3577fb to
e3d71d6
Compare
fredemmott
suggested changes
Nov 8, 2021
Contributor
fredemmott
left a comment
There was a problem hiding this comment.
The implementation/structure seem great, but the naming is very confusing. Changing it will be a BC break, but I think the clarity/tech-debt avoidance is worth it here.
e3d71d6 to
adc9919
Compare
adc9919 to
b4907a5
Compare
b4907a5 to
91f6f43
Compare
fredemmott
approved these changes
Nov 9, 2021
Contributor
fredemmott
left a comment
There was a problem hiding this comment.
Fine to merge as-is, either address before merging or a separate PR
fredemmott
reviewed
Nov 9, 2021
251f6dc to
31f3766
Compare
31f3766 to
717b695
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewing each commit one by one would be easier, because there are multiple commits, which are too messy when reviewing them together.