Skip to content
This repository was archived by the owner on Dec 1, 2024. It is now read-only.

Reuse getLinterName() #376

Merged
Atry merged 1 commit into from
Nov 8, 2021
Merged

Reuse getLinterName() #376

Atry merged 1 commit into from
Nov 8, 2021

Conversation

@Atry
Copy link
Contributor

@Atry Atry commented Nov 6, 2021

No description provided.

@Atry Atry force-pushed the reuse-get-linter-name branch from e46ec5d to 6f12944 Compare November 8, 2021 19:25
fredemmott
fredemmott approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@fredemmott fredemmott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please manually rebase before landing and make sure that the version change commit vanishes

@Atry Atry force-pushed the reuse-get-linter-name branch from 6f12944 to dff374d Compare November 8, 2021 22:09
@Atry Atry force-pushed the reuse-get-linter-name branch from dff374d to f508c3c Compare November 8, 2021 22:14
@Atry Atry merged commit 33ac506 into hhvm:main Nov 8, 2021
@Atry Atry deleted the reuse-get-linter-name branch November 8, 2021 22:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@fredemmott fredemmott fredemmott approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Atry @fredemmott @facebook-github-bot