deriveFixedPoint macro annotation #51
Conversation
| import scala.annotation.compileTimeOnly | ||
|
|
||
| @compileTimeOnly("enable macro paradise to expand macro annotations") | ||
| class fixie extends StaticAnnotation { |
There was a problem hiding this comment.
How do you feel about renaming fixie to deriveFixedPoint?
There was a problem hiding this comment.
Sure thing! Now that it'll be part of droste, the old name doesn't make sense
|
|
||
| val λ: TypeDef = q"type λ[α] = $NonRecursiveAdtName[..${clait.tparams.map(_.name)}, α]" | ||
|
|
||
| val functorInstance = q""" |
There was a problem hiding this comment.
Can we provide a Traverse instead?
There was a problem hiding this comment.
Currently kittens doesn't derive traverse. Only Functor and Foldable in that hierarchy
| "org.typelevel" %%% "cats-core" % "1.1.0", | ||
| "org.typelevel" %%% "cats-free" % "1.1.0")) | ||
| "org.typelevel" %%% "cats-free" % "1.1.0", | ||
| "org.typelevel" %%% "kittens" % "1.1.0", |
There was a problem hiding this comment.
This brings in the kittens dependency. Long term we should see about removing this dependency and instead having macros to generate Functor/Traverse instances without Shapeless.
For now, can we split fixie into a separate module to better isolate the additional dependency? I need to keep the core module dependency free with the exception of the binary compat guaranteed cats modules.
For splitting, what do you think of droste-extras or another similar name?
There was a problem hiding this comment.
Yeah, makes sense. Maybe droste-macros makes more sense? We could put all our macros there and isolate the use of macro paradise.
|
Overall, looks good. My only blocking issue is dependency isolation-- see the note. This opens the door to adding a few other nice macro helpers too :). Very exciting! |
|
@andyscott shall we merge this now? |
andyscott
left a comment
There was a problem hiding this comment.
Just one final tweak! After that, LGTM.
Ideally we squash and merge, or rebase to clean up the commit history (squashing/fixuping the "feedback" commits).
| lazy val coreJVM = core.jvm | ||
| lazy val coreJS = core.js | ||
|
|
||
| lazy val macros = module("macros") |
There was a problem hiding this comment.
Let's add the macros project to the aggregate list at the top on the root project
39d302c to
edad885
Compare
|
🎉 |
@andyscott I'm not sure if I need to add something to the bazel build files, since I'm not an user of it