Consolidated project settings into settings UI #5110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://frontend-pr-5110.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-ch400pseoogj6jv42lsg. |
Vadman97
approved these changes
Apr 26, 2023
frontend/src/components/Header/components/ProjectPicker/ProjectPicker.tsx
Outdated
Show resolved
Hide resolved
deltaepsilon
approved these changes
Apr 26, 2023
Contributor
Author
|
Addressed the comments and added the sidebar border from #5097 Will merge this Monday, since there wasn't any blocking changes when approved last week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Continuing work on new settings UI.
#4917
How did you test this change?
Clicking around and changing settings to make sure they work. Also, checked that URLs are preserved.
Are there any deployment considerations?
NA