Make demo project public #5232
Merged
Make demo project public #5232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://frontend-pr-5232.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cha2optgk4qbt769bq30. |
Vadman97
approved these changes
May 5, 2023
Member
Vadman97
left a comment
There was a problem hiding this comment.
render preview looking great overall, awesome job!
clicking the project dropdown in the top left has an empty box
logs are broken
visiting the alerts page leaks our slack channels
Contributor
Author
Good callout! I'll clean that up.
This is expected! Note the changes to the logs resolvers which should fix these issues.
Will fix this as well! |
…demo-project-public
…demo-project-public
…demo-project-public
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Makes the demo project (the Highlight marketing site) public to people who are not logged in. Also fixes some auth checks for fetching data from the backend where we want to expose them for the demo project.
How did you test this change?
Local and PR preview click test. Tried to hit a number of different
/demo/*routes while logged out and monitored network requests in the devtools to make sure requests weren't failing.Are there any deployment considerations?
N/A