Skip to content

Conversation

@nfiacco
Copy link
Contributor

@nfiacco nfiacco commented May 10, 2023

Summary

Add option to specify specific keys in the request/response body to redact and to record all others by default.

How did you test this change?

Not tested

@Vadman97 Vadman97 requested review from a team and Vadman97 May 10, 2023 22:59
@nfiacco nfiacco force-pushed the nf-redact-body-keys-option branch from 019d889 to 176b8b7 Compare May 10, 2023 23:00
Copy link
Member

@Vadman97 Vadman97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you @nfiacco ! looks great - testing now locally. do you mind fixing the formatting with yarn format:all and bumping the minor version of sdk/firstload/package.json + updating the sdk/firstload/CHANGELOG.md?

Copy link
Member

@Vadman97 Vadman97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good! tested by redacting operationName for local graphql requests
image

@Vadman97 Vadman97 enabled auto-merge (squash) May 11, 2023 23:24
@Vadman97 Vadman97 merged commit f6ec09c into highlight:main May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants