update mui injection logic for synder #5292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://frontend-pr-5292.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-che8ahorddlfhtm6rah0. |
mayberryzane
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For some projects, we need to inject styles when we are replaying to ensure the replay looks correct.
Ensure we do this after applying rrweb mutations to make sure the styles are rendered correctly.
Enables media asset inlining for this project.
How did you test this change?
before
after
https://frontend-pr-5292.onrender.com/1031/sessions/6MvXaWNjUZ9RW6wuANX4QCKYZ79h
https://frontend-pr-5292.onrender.com/1031/sessions/7S4SqSsK5nNRmrqNf7ObE8rMJGFD
Are there any deployment considerations?
No