Endpoint that saves all settings #5387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://frontend-pr-5387.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-chk0gq1mbg50titjvidg. |
Contributor
|
I'm removing myself from the Reviewers list and nominating @et! I have no idea what this code does. |
et
added a commit
that referenced
this pull request
Jun 1, 2023
## Summary <!-- Ideally, there is an attached GitHub issue that will describe the "why". If relevant, use this section to call out any additional information you'd like to _highlight_ to the reviewer. --> This PR cleans up some unused endpoints that is no longer needed since we created a consolidated endpoint to save all project settings (#5387). ## How did you test this change? <!-- Frontend - Leave a screencast or a screenshot to visually describe the changes. --> * Confirmed that updating project settings (that exist on the project_filter_settings table) correctly update * Added tests ## Are there any deployment considerations? <!-- Backend - Do we need to consider migrations or backfilling data? --> N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Figma for the new settings show that project settings are saved using a single button. This PR adds that endpoint, and changed much of the logic in the project settings to use the new context that manages settings.
Discussion in Slack about it: https://highlightcorp.slack.com/archives/C01FJL7V630/p1683905993153839
How did you test this change?
Are there any deployment considerations?