Skip to content

fix overage cards when on free trial #5383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mayberryzane merged 1 commit into from
May 19, 2023
Merged

fix overage cards when on free trial #5383

mayberryzane merged 1 commit into from
May 19, 2023

Conversation

@mayberryzane
Copy link
Contributor

@mayberryzane mayberryzane commented May 19, 2023

Summary

  • overage cards were showing if exceeding the free tier limits but on the free trial

How did you test this change?

  • tested the GetBillingDetailsForProject query locally with null, past, and future trial_end_date

Are there any deployment considerations?

  • no

@mayberryzane mayberryzane requested review from a team and et and removed request for a team May 19, 2023 19:48
@mayberryzane mayberryzane enabled auto-merge (squash) May 19, 2023 19:48
@mayberryzane mayberryzane merged commit 39563f9 into main May 19, 2023
@mayberryzane mayberryzane deleted the zane/fix_limit_trial branch May 19, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Vadman97 Vadman97 Vadman97 approved these changes

@et et Awaiting requested review from et et was automatically assigned from highlight/full-stack-devs

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mayberryzane @Vadman97