New project settings UI #5391
Merged
New project settings UI #5391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbf93f1 to
3c5071c
Compare
|
Your Render PR Server URL is https://frontend-pr-5391.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-chlqske4dad72klr5kg0. |
et
approved these changes
May 22, 2023
Contributor
et
left a comment
There was a problem hiding this comment.
Great cleanup here!
One thing I noticed is that we don't have a loading state for these forms and the inputs jump when the data loads in.
See this gif and watch the toggle for "Filter errors thrown by Chrome extensions"
I don't think we need to fix this immediately but it would be great to fix this at some point.
Contributor
Author
|
Loading state is currently being worked on. Will be getting a pr out for it later today! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
New project settings ui for sessions and error settings. Mostly the section cards and text.
Currently not heavily modified to match the Figma: Input and Select components.
The inputs seem to be reused throughout the app, so I kept them the same for now. Inputs can be changed in a future PR, possibly by making a SelectV2 or InputV2.
https://www.figma.com/file/rdBPNzn7Klk6RG1LHUCE5B/Screen-Designs?type=design&node-id=7765-360301&t=Bxv5Eh5GdtXD0TwH-0
How did you test this change?