Skip to content

#4265 misc segment fixes #5526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mayberryzane merged 1 commit into from
Jun 5, 2023
Merged

#4265 misc segment fixes #5526

mayberryzane merged 1 commit into from
Jun 5, 2023

Conversation

@mayberryzane
Copy link
Contributor

@mayberryzane mayberryzane commented Jun 2, 2023 •
edited
Loading

Summary

  • fix issue where updating an existing segment was failing the "name already exists" validation
  • preventdefault on dropdown click to avoid menu popping up for a split second
  • remove buttons and interactive features from "readonly" state
Screen Shot 2023-06-02 at 11 28 13 AM
  • working on changes for relative date range (e.g. "last 7 days") in separate PR

How did you test this change?

  • click tested locally

Are there any deployment considerations?

  • no

@render
Copy link

render bot commented Jun 2, 2023

Your Render PR Server URL is https://frontend-pr-5526.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cht3bvjhp8ue5s1qgtr0.

@mayberryzane mayberryzane requested review from a team and et and removed request for a team June 2, 2023 18:33
@mayberryzane mayberryzane changed the title misc segment fixes #4265 misc segment fixes Jun 2, 2023
@mayberryzane mayberryzane merged commit 9c41ece into main Jun 5, 2023
@mayberryzane mayberryzane deleted the zane/segment_fixes branch June 5, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@et et et approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mayberryzane @et