Skip to content

Conversation

@eightants
Copy link
Contributor

@eightants eightants commented Jun 27, 2023

Summary

Added button to trigger session insights as specified in #5687

Also fixed the backend insights retry function when local server is unavailable.

Screenshot 2023-06-27 at 12 43 11 PM

@render
Copy link

render bot commented Jun 27, 2023

@eightants eightants requested review from a team and SpennyNDaJets and removed request for a team June 27, 2023 14:47
@reflame reflame bot temporarily deployed to Preview June 27, 2023 16:41 Destroyed
Copy link
Member

@Vadman97 Vadman97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated to this PR, but just noticed that insights can come out of order. can we update the prompt to fix that?

image

Copy link
Contributor

@SpennyNDaJets SpennyNDaJets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanted to just raise the following things I found from click testing:

  1. The Button is not there after generating a response, and then changing sessions. Not sure if its automatically hitting our endpoint, or stuck in a loading loop though 🤔
  2. The times seem to be off, but not sure if this is a local/unrelated issue
    Screenshot 2023-06-27 at 12 53 10 PM

@eightants
Copy link
Contributor Author

Wanted to just raise the following things I found from click testing:

  1. The Button is not there after generating a response, and then changing sessions. Not sure if its automatically hitting our endpoint, or stuck in a loading loop though 🤔
  2. The times seem to be off, but not sure if this is a local/unrelated issue
    Screenshot 2023-06-27 at 12 53 10 PM
  1. Yeah this is cause we're using a production session in s3 to get all session events, so the timestamps on that session doesn't match the local session

Copy link
Member

@Vadman97 Vadman97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small note on the loading button
also the insights seem to be broken in the lambda
https://www.loom.com/share/14373574d53942e390988be0efd2fffa

Copy link
Member

@Vadman97 Vadman97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

realized that the lambda might be broken in the render.com preview since that doesn't deploy the backend changes, in which case disregard!

@eightants eightants merged commit 9ba068b into main Jun 30, 2023
@eightants eightants deleted the 5687-add-an-explicit-button-for-generating-session-summary branch June 30, 2023 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants