add echo middleware to Go SDK #5841
Conversation
Vadman97
left a comment
There was a problem hiding this comment.
sorry we haven't gotten back to you sooner here! code looks great other than a cleanup with the go dependencies.
could you also add docs for the new middleware? you'll need to change
- https://github.com/highlight/highlight/tree/main/docs-content/getting-started/4_backend-sdk/go
- https://github.com/highlight/highlight/tree/6d643dc458fea223573e90cfb702e710068f8890/highlight.io/components/QuickstartContent/backend/go
it would also be nice if you could add an example echo app using the middleware in https://github.com/highlight/highlight/tree/main/e2e/go
|
hey @chancesm , any chance you could take another look at the remaining questions? |
|
Sorry. I've been busy with work and some personal stuff. I'll try to look
at it soon 🙂
…On Fri, Aug 11, 2023, 2:19 PM Vadim Korolik ***@***.***> wrote:
hey @chancesm <https://github.com/chancesm> , any chance you could take
another look at the remaining questions?
—
Reply to this email directly, view it on GitHub
<#5841 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEZ43BVZ2KKBL6X2MFOMFLLXU2HVTANCNFSM6AAAAAA2CTDQTQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
9cb8835 to
1c31b35
Compare
If there is anything else you would like me to do as part of this PR, please let me know 🙂 |
Vadman97
left a comment
There was a problem hiding this comment.
🚢 thank you for your contribution!
|
@chancesm should be good to go, but mind updating the description about how this was tested? could you try running the example you are adding locally to ensure this works correctly as an echo middleware? |
|
@Vadman97 I'll do that this weekend 👍🏻 |
## Summary I was wanting something to work on so I felt like adding a middleware for echo for your Go SDK. I did follow the patterns established in the other middleware options while working on this one. This is also one of my first OSS PRs so if you need me to change anything at all, please let me know. ## How did you test this change? I have not tested this change yet ## Are there any deployment considerations? Nope 😄 --------- Co-authored-by: Vadim Korolik <vadim@highlight.io>
Summary
I was wanting something to work on so I felt like adding a middleware for echo for your Go SDK. I did follow the patterns established in the other middleware options while working on this one. This is also one of my first OSS PRs so if you need me to change anything at all, please let me know.
How did you test this change?
I have not tested this change yet
Are there any deployment considerations?
Nope 😄