Fix duplicate trace rows and reenable writing trace #6249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ccschmitz
commented
Aug 7, 2023
Vadman97
approved these changes
Aug 7, 2023
Contributor
Author
|
@mayberryzane let me know if you think we should move to async writes now or if that's something we should consider in a follow up. |
Contributor
It's probably worth doing now since we were getting |
mayberryzane
approved these changes
Aug 7, 2023
ccschmitz
commented
Aug 9, 2023
ccschmitz
added a commit
that referenced
this pull request
Aug 10, 2023
This reverts commit 037218e.
mayberryzane
pushed a commit
that referenced
this pull request
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Re-enables writing traces to Clickhouse and fixes a bug where we were duplicating traces.
How did you test this change?
Unit test - see the new assertion on
len(tracesMessage.PushTraces.TraceRows).Are there any deployment considerations?
Will monitor Clickhouse metrics once this rolls out.