Skip to content

Conversation

@mayberryzane
Copy link
Contributor

Summary

  • flush logs should flush every ~10k log rows (ideal per the clickhouse docs)
  • previously, it was using the Kafka batch size, but each Kafka message has multiple log rows, so there would be unread messages until the next flush
  • now, loop and flush all messages until the message queue is empty

How did you test this change?

  • tested locally to make sure log ingestion was working, will monitor in prod

Are there any deployment considerations?

  • no

@mayberryzane mayberryzane merged commit b25147d into main Aug 4, 2023
@mayberryzane mayberryzane deleted the zane/kafka_batched_tune branch August 4, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants