add a publish step for ruby sdk #6269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 8, 2023 11:20
mayberryzane
approved these changes
Aug 9, 2023
Contributor
mayberryzane
left a comment
There was a problem hiding this comment.
🙌 thanks for getting that set up!
et
added a commit
that referenced
this pull request
Aug 10, 2023
## Summary <!-- Ideally, there is an attached GitHub issue that will describe the "why". If relevant, use this section to call out any additional information you'd like to _highlight_ to the reviewer. --> Adds service name and service version to ruby sdk. ## How did you test this change? <!-- Frontend - Leave a screencast or a screenshot to visually describe the changes. --> The tests hit a live account which actually makes the testing easier. ``` bundle exec rake ``` Observe log ([permalink](https://app.highlight.io/1394/logs/MjAyMy0wOC0wOVQyMDowNjowNVosOWU1YzY1MDktNWMxZS00ZGJkLWIwNTMtZDE2MGQzZTM2MzQ0)).  ## Are there any deployment considerations? <!-- Backend - Do we need to consider migrations or backfilling data? --> Docs updated and bumped ruby version (should autodeploy now per #6269 but will verify on [rubygems](https://rubygems.org/gems/highlight_io) after this is merged).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Similar to our python publish build step, this adds a workflow for automating publishing ruby gems.
One distinction is that
poetryhas a--skip-existingflag which means that it won't error if an existing package with the same version exists. From what I could tellgem pushdoesn't have a equivalent behavior (docs).How did you test this change?
Before adding a guard for running only on main (
if: github.ref == 'refs/heads/main'), I verified that publish complains about the existing version (see build output).I intend to update the version when adding a service config (#6229) and will be able to confirm that the published version is correctly uploaded to rubygems.
Are there any deployment considerations?
N/A