fix: add isOnErrorsPage flag check to hide DropDownMenu #6440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayberryzane
approved these changes
Aug 28, 2023
Contributor
mayberryzane
left a comment
There was a problem hiding this comment.
Thanks @jainpawan21 ! looks good to me
lewisl9029
pushed a commit
to lewisl9029/highlight
that referenced
this pull request
Nov 16, 2023
## Summary 1. Used `useLocation` hook from `react-router-dom` 2. Used isOnErrorsPage flag check to conditionally render `<DropdownMenu>` closes highlight#6405 <!-- Ideally, there is an attached GitHub issue that will describe the "why". If relevant, use this section to call out any additional information you'd like to _highlight_ to the reviewer. --> ## How did you test this change? https://github.com/highlight/highlight/assets/39362422/d1dd042f-7ac0-49c0-85eb-d826fc899365 <!-- Frontend - Leave a screencast or a screenshot to visually describe the changes. --> ## Are there any deployment considerations? <!-- Backend - Do we need to consider migrations or backfilling data? -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
useLocationhook fromreact-router-dom<DropdownMenu>closes #6405
How did you test this change?
Screen.Recording.2023-08-26.at.11.07.47.PM.mov
Are there any deployment considerations?