Skip to content

Conversation

@SpennyNDaJets
Copy link
Contributor

@SpennyNDaJets SpennyNDaJets commented Sep 5, 2023

Summary

The dependencies are not hoisted into the root level of the node modules, causing Vercel to error out when looking for the first none highlight workspace dependencie (e.g. @next/env). Update the hoistingLimits to include dependencies.

How did you test this change?

  1. Vercel build passes
  • Build passes
  1. Able to deploy Next E2E app
  • Deploy works

Are there any deployment considerations?

N/A

@deltaepsilon
Copy link
Contributor

I think this solved a problem of mine as well. Good find!

@SpennyNDaJets SpennyNDaJets merged commit 5340d6a into main Sep 6, 2023
@SpennyNDaJets SpennyNDaJets deleted the spenny/test-versel-deployment branch September 6, 2023 16:20
@SpennyNDaJets SpennyNDaJets changed the title Test vercel deployment Fix vercel deployment Sep 6, 2023
lewisl9029 pushed a commit to lewisl9029/highlight that referenced this pull request Nov 16, 2023
## Summary
The dependencies are not hoisted into the root level of the node
modules, causing Vercel to error out when looking for the first none
highlight workspace dependencie (e.g. `@next/env`). Update the
hoistingLimits to include dependencies.

## How did you test this change?
1) Vercel build passes
- [ ] Build passes
2) Able to deploy Next E2E app
- [ ] Deploy works

## Are there any deployment considerations?
N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants