Skip to content

add rfc on adding changesets #6561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Vadman97 merged 5 commits into from
Oct 5, 2023
Merged

add rfc on adding changesets #6561

Vadman97 merged 5 commits into from
Oct 5, 2023

Conversation

@Vadman97
Copy link
Member

@Vadman97 Vadman97 commented Sep 7, 2023 •
edited
Loading

Summary

Adds a new doc on using changesets to publish js packages.
Configures changesets for our monorepo.

In short, run yarn changeset locally when making changes to published js packages.

How did you test this change?

CI

Are there any deployment considerations?

Will monitoring github action in main.

Does this work require review from our design team?

No

@Vadman97 Vadman97 changed the title WIP initial commit add rfc on adding changesets Sep 7, 2023
@Vadman97 Vadman97 force-pushed the vadim/rfc-changesets branch from 43995e4 to e60e7f3 Compare October 4, 2023 06:28
@vercel
Copy link

vercel bot commented Oct 4, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
highlight-landing ✅ Ready (Inspect) Visit Preview Oct 4, 2023 6:39am

@Vadman97 Vadman97 force-pushed the vadim/rfc-changesets branch from e60e7f3 to 48ee56b Compare October 4, 2023 19:46
@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7c504c0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR 
Some errors occurred when validating the changesets config:
The package or glob expression "@highlight-run/rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@Vadman97 Vadman97 requested review from a team and ccschmitz and removed request for a team October 4, 2023 19:57
@Vadman97 Vadman97 marked this pull request as ready for review October 4, 2023 19:57
@Vadman97 Vadman97 requested review from a team and mayberryzane and removed request for a team and ccschmitz October 5, 2023 16:15
@Vadman97 Vadman97 force-pushed the vadim/rfc-changesets branch from ccae5bf to 7c504c0 Compare October 5, 2023 20:14
@Vadman97 Vadman97 enabled auto-merge (squash) October 5, 2023 20:19
@Vadman97 Vadman97 merged commit b9026ec into main Oct 5, 2023
@Vadman97 Vadman97 deleted the vadim/rfc-changesets branch October 5, 2023 20:34
lewisl9029 pushed a commit to lewisl9029/highlight that referenced this pull request Nov 16, 2023
@Vadman97 @lewisl9029
add rfc on adding changesets (highlight#6561)
60c14dc 
## Summary

Adds a [new
doc](https://github.com/highlight/highlight/blob/c99084498ced39240f90a39de3606a4942b3fcfb/internal-docs/rfcs/003-changesets.md)
on using changesets to publish js packages.
Configures changesets for our monorepo.

In short, run `yarn changeset` locally when making changes to published
js packages.

## How did you test this change?

CI

## Are there any deployment considerations?

Will monitoring github action in main.

## Does this work require review from our design team?

No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mayberryzane mayberryzane Awaiting requested review from mayberryzane mayberryzane was automatically assigned from highlight/full-stack-devs

1 more reviewer

@deltaepsilon deltaepsilon deltaepsilon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Vadman97 @deltaepsilon