Fixes log alert query not saving #6633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e function to be more clear
2935b4a to
68e2d70
Compare
SpennyNDaJets
approved these changes
Sep 18, 2023
Contributor
SpennyNDaJets
left a comment
There was a problem hiding this comment.
Code and click test look good to me!
Member
|
@anthonygregis linter seems to be failing could you run |
Contributor
Author
|
Sorry about that, will run and push up |
Member
|
@anthonygregis no worries. looks like the yarn.lock changes are local to your project, do you mind removing that from your PR? |
Contributor
Author
|
@Vadman97 @SpennyNDaJets Will fix yarn.lock issue now, most likely happened because I'm on Windows. |
lewisl9029
pushed a commit
to lewisl9029/highlight
that referenced
this pull request
Nov 16, 2023
## Summary This resolves an issue when defining a log alert query. When a user inputs a log query the value was being set into a local variable to update the histogram but was not updating the formStore that was being used to populate the mutation input variables. This PR should resolve this issue and allow for query to be sent along to the mutation. Related Issue: highlight#6630 ## How did you test this change? Test both locally and in self deployed version ## Are there any deployment considerations? None, purely frontend changes ## Does this work require review from our design team? No --------- Co-authored-by: Anthony Gregis <agregis@dustlabs.com> Co-authored-by: TheBasedBob <bob@degods.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This resolves an issue when defining a log alert query. When a user inputs a log query the value was being set into a local variable to update the histogram but was not updating the formStore that was being used to populate the mutation input variables. This PR should resolve this issue and allow for query to be sent along to the mutation.
Related Issue: #6630
How did you test this change?
Test both locally and in self deployed version
Are there any deployment considerations?
None, purely frontend changes
Does this work require review from our design team?
No