fixes highlight/highlight#6716 #6717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vadman97
reviewed
Sep 26, 2023
Member
Vadman97
left a comment
There was a problem hiding this comment.
thank you for the contribution @MichaelCGrant ! mind sharing how you've validated that this fixes the typescript error you were seeing? curious if you have ideas on what we can do to catch this in our test automation as well (perhaps with a tsc invocation that mirrors your vscode setup)
Vadman97
approved these changes
Sep 28, 2023
lewisl9029
pushed a commit
to lewisl9029/highlight
that referenced
this pull request
Nov 16, 2023
## Summary added client.d.ts to "files" section of package.json Co-authored-by: Mike Grant <michael.grant@erdosmiller.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
added client.d.ts to "files" section of package.json