Skip to content

Conversation

@Vadman97
Copy link
Member

@Vadman97 Vadman97 commented Oct 4, 2023

Summary

Loosens python SDK dependency to support python >=3.7, <4
Previously, the version of django required python >=3.8
Validates that our SDK integrations are functional for the looser set of versions.

How did you test this change?

flask
image

django
image

fastapi
image

Are there any deployment considerations?

New python SDK version released

Does this work require review from our design team?

No

@Vadman97 Vadman97 requested review from a team and deltaepsilon and removed request for a team October 4, 2023 16:43
@vercel
Copy link

vercel bot commented Oct 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
highlight-landing ✅ Ready (Inspect) Visit Preview Oct 4, 2023 4:49pm

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
299 254 85% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: bd89154 by action🐍

@Vadman97 Vadman97 merged commit 3bcaf63 into main Oct 4, 2023
@Vadman97 Vadman97 deleted the vadim/loosen-python-version branch October 4, 2023 20:19
lewisl9029 pushed a commit to lewisl9029/highlight that referenced this pull request Nov 16, 2023
## Summary

Loosens python SDK dependency to support python >=3.7, <4
Previously, the version of django required python >=3.8
Validates that our SDK integrations are functional for the looser set of
versions.

## How did you test this change?

flask

![image](https://github.com/highlight/highlight/assets/1351531/ca374893-4a0c-4790-bc0a-4cc40b62d57f)

django

![image](https://github.com/highlight/highlight/assets/1351531/bb17afee-4e99-41f7-900d-deea3d467ad0)

fastapi

![image](https://github.com/highlight/highlight/assets/1351531/2828ec91-82b2-4d7d-ba38-23d3c404b0ef)


## Are there any deployment considerations?

New python SDK version released

## Does this work require review from our design team?

No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants