Skip to content

Traces table refinements #6840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ccschmitz merged 9 commits into from
Oct 11, 2023
Merged

Traces table refinements #6840

ccschmitz merged 9 commits into from
Oct 11, 2023

Conversation

@ccschmitz
Copy link
Contributor

@ccschmitz ccschmitz commented Oct 10, 2023 •
edited
Loading

Summary

  • Cleans up some table of the interactive table styles on rows and cells
  • Tightens up the content on the traces table and fixes some styling issues
  • Ensures we don't lose search params when viewing individual traces
Screenshot 2023-10-11 at 6 26 03 AM

How did you test this change?

Local + PR preview click tests.

Are there any deployment considerations?

All client-side changes only and the page is only visible to Highlight admins.

Does this work require review from our design team?

Will have Julian click test when this goes out!

@ccschmitz ccschmitz linked an issue Oct 10, 2023 that may be closed by this pull request
Individual trace view refinements #6820
Closed
@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: a078fce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR 
Some errors occurred when validating the changesets config:
The package or glob expression "@highlight-run/rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@render
Copy link

render bot commented Oct 10, 2023

Your Render PR Server URL is https://frontend-pr-6840.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-ckiq82q12bvs73fth15g.

@ccschmitz ccschmitz linked an issue Oct 10, 2023 that may be closed by this pull request
Table polish: Ensure everything at every length of text is still stays true to the layout #6744
Closed
ccschmitz
ccschmitz commented Oct 11, 2023
View reviewed changes
ccschmitz
ccschmitz commented Oct 11, 2023
View reviewed changes
@ccschmitz ccschmitz marked this pull request as ready for review October 11, 2023 12:14
@ccschmitz ccschmitz requested review from a team and SpennyNDaJets and removed request for a team October 11, 2023 12:14
SpennyNDaJets
SpennyNDaJets approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@SpennyNDaJets SpennyNDaJets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Click tested a few instances of the table to check that it works!

@SpennyNDaJets
Copy link
Contributor

SpennyNDaJets commented Oct 11, 2023

@ccschmitz possibly unrelated but noticed this weird grey shading when searching for a field
Screenshot 2023-10-11 at 10 16 29 AM

@ccschmitz
Copy link
Contributor Author

ccschmitz commented Oct 11, 2023

@SpennyNDaJets thanks for the review and mentioning that! I think that is a bug with highlighting search terms. I can look into this in #6825!

@ccschmitz ccschmitz enabled auto-merge (squash) October 11, 2023 14:35
@ccschmitz ccschmitz merged commit 6ab619d into main Oct 11, 2023
@ccschmitz ccschmitz deleted the 6820-individual-trace-view-refinements branch October 11, 2023 14:35
lewisl9029 pushed a commit to lewisl9029/highlight that referenced this pull request Nov 16, 2023
@ccschmitz @lewisl9029
Traces table refinements (highlight#6840)
572bf86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SpennyNDaJets SpennyNDaJets SpennyNDaJets approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Individual trace view refinements Table polish: Ensure everything at every length of text is still stays true to the layout

3 participants

@ccschmitz @SpennyNDaJets