Skip to content

Fix error instance overflow #6841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SpennyNDaJets merged 2 commits into from
Oct 11, 2023
Merged

Fix error instance overflow #6841

SpennyNDaJets merged 2 commits into from
Oct 11, 2023

Conversation

@SpennyNDaJets
Copy link
Contributor

@SpennyNDaJets SpennyNDaJets commented Oct 10, 2023

Summary

When the error instance event is over a certain amount of lines, it overflows into the other content. Allow the container to grow and scroll when necessary.

https://www.loom.com/share/aa4c61e67d52492cb8b40d354ca34896?sid=91820b21-6462-4fc8-a414-5a179953aba5

How did you test this change?

  1. Fix the error event to a long excerpt of text
  2. View the error instance on the error show page
  • Clicking see more shows the entire error event with no overflow
  1. View a session with an error, and click to display an error in the right panel
  • Clicking see more shows the entire error event with no overflow

Are there any deployment considerations?

N/A

Does this work require review from our design team?

N/A

@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5c3416a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR 
Some errors occurred when validating the changesets config:
The package or glob expression "@highlight-run/rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@render
Copy link

render bot commented Oct 10, 2023

Your Render PR Server URL is https://frontend-pr-6841.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-ckis5guv3ddc73cvqb20.

@SpennyNDaJets SpennyNDaJets linked an issue Oct 10, 2023 that may be closed by this pull request
error instance overflow #6822
Closed
@SpennyNDaJets SpennyNDaJets marked this pull request as ready for review October 10, 2023 21:37
@SpennyNDaJets SpennyNDaJets requested review from a team and mayberryzane and removed request for a team October 10, 2023 21:37
@SpennyNDaJets SpennyNDaJets merged commit a52e610 into main Oct 11, 2023
@SpennyNDaJets SpennyNDaJets deleted the spenny/fix-error-instance-overflow branch October 11, 2023 18:10
lewisl9029 pushed a commit to lewisl9029/highlight that referenced this pull request Nov 16, 2023
@SpennyNDaJets @lewisl9029
Fix error instance overflow (highlight#6841)
7a00ea6 
## Summary
When the error instance event is over a certain amount of lines, it
overflows into the other content. Allow the container to grow and scroll
when necessary.


https://www.loom.com/share/aa4c61e67d52492cb8b40d354ca34896?sid=91820b21-6462-4fc8-a414-5a179953aba5

## How did you test this change?
1) Fix the error event to a long excerpt of text
2) View the error instance on the error show page
- [ ] Clicking see more shows the entire error event with no overflow
3) View a session with an error, and click to display an error in the
right panel
- [ ] Clicking see more shows the entire error event with no overflow

## Are there any deployment considerations?
N/A

## Does this work require review from our design team?
N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mayberryzane mayberryzane mayberryzane approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

error instance overflow

3 participants

@SpennyNDaJets @mayberryzane