Skip to content

Remove unnecessary privacy doc #6882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jay-khatri merged 2 commits into from
Oct 20, 2023
Merged

Remove unnecessary privacy doc #6882

jay-khatri merged 2 commits into from
Oct 20, 2023

Conversation

@jay-khatri
Copy link
Collaborator

@jay-khatri jay-khatri commented Oct 18, 2023 •
edited
Loading

Summary

Removes an unnecessary privacy doc here: https://www.highlight.io/docs/general/product-features/session-replay/privacy.

How did you test this change?

Click test.

Are there any deployment considerations?

no

Does this work require review from our design team?

no

@changeset-bot
Copy link

changeset-bot bot commented Oct 18, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: e728496

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR 
Some errors occurred when validating the changesets config:
The package or glob expression "@highlight-run/rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@jay-khatri jay-khatri changed the title Privacy Doc Remove unecessary privacy doc Oct 18, 2023
@jay-khatri jay-khatri changed the title Remove unecessary privacy doc Remove unnecessary privacy doc Oct 18, 2023
Vadman97
Vadman97 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@Vadman97 Vadman97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like there are other pointers to this deleted file that need to be updated
https://github.com/highlight/highlight/actions/runs/6564577023/job/17831220718

doc: /sdk/client.md
  link: /home/runner/actions-runner/_work/highlight/highlight/docs-content/general/6_product-features/1_session-replay/privacy.md

@jay-khatri jay-khatri enabled auto-merge (squash) October 20, 2023 00:06
@jay-khatri jay-khatri merged commit 7d09ee6 into main Oct 20, 2023
@jay-khatri jay-khatri deleted the jay-khatri-remove-privacy-doc branch October 20, 2023 00:23
lewisl9029 pushed a commit to lewisl9029/highlight that referenced this pull request Nov 16, 2023
@jay-khatri @lewisl9029
Remove unnecessary privacy doc (highlight#6882)
a68ce9c 
## Summary

Removes an unnecessary privacy doc here:
https://www.highlight.io/docs/general/product-features/session-replay/privacy.

<!--
Ideally, there is an attached GitHub issue that will describe the "why".

If relevant, use this section to call out any additional information
you'd like to _highlight_ to the reviewer.
-->

## How did you test this change?

Click test.

<!--
Frontend - Leave a screencast or a screenshot to visually describe the
changes.
-->

## Are there any deployment considerations?
no

<!--
 Backend - Do we need to consider migrations or backfilling data?
-->

## Does this work require review from our design team?
no
<!--
 Request review from julian-highlight / our design team 
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Vadman97 Vadman97 Vadman97 approved these changes

@SpennyNDaJets SpennyNDaJets SpennyNDaJets approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jay-khatri @Vadman97 @SpennyNDaJets