Skip to content

remove feature flags from traces #6890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mayberryzane merged 2 commits into from
Oct 19, 2023
Merged

remove feature flags from traces #6890

mayberryzane merged 2 commits into from
Oct 19, 2023

Conversation

@mayberryzane
Copy link
Contributor

@mayberryzane mayberryzane commented Oct 19, 2023 •
edited
Loading

Summary

  • removes the highlight admin checks from showing traces in the navbar and traces in the setup menu

How did you test this change?

  • click tested locally

Are there any deployment considerations?

  • will deploy this sometime between now and 9am tomorrow

Does this work require review from our design team?

  • no

@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 30d0687

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR 
Some errors occurred when validating the changesets config:
The package or glob expression "@highlight-run/rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@render
Copy link

render bot commented Oct 19, 2023

Your Render PR Server URL is https://frontend-pr-6890.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-ckoa3c1rfc9c73bovhmg.

@mayberryzane mayberryzane requested a review from Vadman97 October 19, 2023 03:25
@sweep-ai-deprecated
Copy link
Contributor

sweep-ai-deprecated bot commented Oct 19, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@mayberryzane mayberryzane merged commit 404bc7a into main Oct 19, 2023
@mayberryzane mayberryzane deleted the zane/remove_feature_flags branch October 19, 2023 15:01
@Vadman97
Copy link
Member

Vadman97 commented Oct 19, 2023

🚢

lewisl9029 pushed a commit to lewisl9029/highlight that referenced this pull request Nov 16, 2023
@mayberryzane @lewisl9029
remove feature flags from traces (highlight#6890)
fc93c54 
## Summary
- removes the highlight admin checks from showing traces in the navbar
and traces in the setup menu
<!--
Ideally, there is an attached GitHub issue that will describe the "why".

If relevant, use this section to call out any additional information
you'd like to _highlight_ to the reviewer.
-->

## How did you test this change?
- click tested locally
<!--
Frontend - Leave a screencast or a screenshot to visually describe the
changes.
-->

## Are there any deployment considerations?
- will deploy this sometime between now and 9am tomorrow
<!--
 Backend - Do we need to consider migrations or backfilling data?
-->

## Does this work require review from our design team?
- no
<!--
 Request review from julian-highlight / our design team 
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Vadman97 Vadman97 Awaiting requested review from Vadman97

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mayberryzane @Vadman97