Skip to content

Small tweaks to session replay post #6921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jay-khatri merged 2 commits into from
Oct 21, 2023
Merged

Small tweaks to session replay post #6921

jay-khatri merged 2 commits into from
Oct 21, 2023

Conversation

@jay-khatri
Copy link
Collaborator

@jay-khatri jay-khatri commented Oct 21, 2023

Summary

Small tweaks to session replay post

How did you test this change?

clicktest

Are there any deployment considerations?

n/a

Does this work require review from our design team?

n/a

@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: ef5b7c8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR 
Some errors occurred when validating the changesets config:
The package or glob expression "@highlight-run/rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@highlight-run/rrweb-web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@jay-khatri jay-khatri enabled auto-merge (squash) October 21, 2023 20:29
@jay-khatri jay-khatri merged commit 8514598 into main Oct 21, 2023
@jay-khatri jay-khatri deleted the jay-khatri-small-session-replay-tweaks branch October 21, 2023 20:59
lewisl9029 pushed a commit to lewisl9029/highlight that referenced this pull request Nov 16, 2023
@jay-khatri @lewisl9029
Small tweaks to session replay post (highlight#6921)
f0b3597 
## Summary

Small tweaks to session replay post
<!--
Ideally, there is an attached GitHub issue that will describe the "why".

If relevant, use this section to call out any additional information
you'd like to _highlight_ to the reviewer.
-->

## How did you test this change?

clicktest
<!--
Frontend - Leave a screencast or a screenshot to visually describe the
changes.
-->

## Are there any deployment considerations?
n/a
<!--
 Backend - Do we need to consider migrations or backfilling data?
-->

## Does this work require review from our design team?
n/a

<!--
 Request review from julian-highlight / our design team 
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Vadman97 Vadman97 Vadman97 approved these changes

@Abhishek-More Abhishek-More Awaiting requested review from Abhishek-More

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jay-khatri @Vadman97