Skip to content

cleanup billing history graphs ranges and tooltips #8689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Vadman97 merged 3 commits into from
May 30, 2024
Merged

cleanup billing history graphs ranges and tooltips #8689

Vadman97 merged 3 commits into from
May 30, 2024

Conversation

@Vadman97
Copy link
Member

@Vadman97 Vadman97 commented May 29, 2024 •
edited
Loading

Summary

  • fixes billing history graphs not loading for active subscriptions
  • fixes date ranges for each par on the billing history graphs
  • adds a daily option to the billing history graphs
  • fixes tooltip styling on sessions feed and on billing page

How did you test this change?

reflame billing page, session feed

Screenshot from 2024-05-29 11-39-18
Screenshot from 2024-05-29 11-39-50

Are there any deployment considerations?

no

Does this work require review from our design team?

yes

@linear
Copy link

linear bot commented May 29, 2024

SUP-44 Weekly graphs in the screenshot are not loading, but switching to monthly and then back to weekly makes them load correctly

@changeset-bot
Copy link

changeset-bot bot commented May 29, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9f14f2c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR 
Some errors occurred when validating the changesets config:
The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@Vadman97 Vadman97 requested review from a team, SpennyNDaJets and julian-highlight and removed request for a team May 29, 2024 18:22
@Vadman97 Vadman97 marked this pull request as ready for review May 29, 2024 18:31
@Vadman97 Vadman97 force-pushed the sup-44-weekly-graphs-in-the-screenshot-are-not-loading-but branch from 453200a to 833b60f Compare May 29, 2024 18:32
@Vadman97 Vadman97 force-pushed the sup-44-weekly-graphs-in-the-screenshot-are-not-loading-but branch from 833b60f to 8d2dec3 Compare May 29, 2024 18:32
@julian-highlight
Copy link

julian-highlight commented May 30, 2024

There's some issues on the position of the barcharts:
image
@Vadman97

Everything else looks great!

SpennyNDaJets
SpennyNDaJets approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@SpennyNDaJets SpennyNDaJets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vadman97 Vadman97 enabled auto-merge (squash) May 30, 2024 20:32
@Vadman97 Vadman97 merged commit bfe2338 into main May 30, 2024
@Vadman97 Vadman97 deleted the sup-44-weekly-graphs-in-the-screenshot-are-not-loading-but branch May 30, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SpennyNDaJets SpennyNDaJets SpennyNDaJets approved these changes

@julian-highlight julian-highlight Awaiting requested review from julian-highlight

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Vadman97 @julian-highlight @SpennyNDaJets