Skip to content

[HIG-4596] related resources from metric dashboards #8991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mayberryzane merged 12 commits into from
Jul 28, 2024
Merged

[HIG-4596] related resources from metric dashboards #8991

mayberryzane merged 12 commits into from
Jul 28, 2024

Conversation

@mayberryzane
Copy link
Contributor

@mayberryzane mayberryzane commented Jul 22, 2024 •
edited
Loading

Summary

  • some small backend changes for error objects:
    • allow error objects to be queried either by error object id or project id
    • return errorGroupSecureId
  • frontend implementation of related resources
  • for now, clicking on an individual line or bar will open the right panel with the correct resource
  • logs uses the existing logs list view
  • traces / sessions / errors introduces a new RelatedResourceList - borrows heavily from the existing TracesTable but allows for different columns to be used depending on the resource

How did you test this change?

  • clicktested locally

Are there any deployment considerations?

  • releasing behind admin flag
  • following this up with HIG-4816

Does this work require review from our design team?

@changeset-bot
Copy link

changeset-bot bot commented Jul 22, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6342254

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR 
Some errors occurred when validating the changesets config:
The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/all" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/record" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/replay" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/packer" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/rrweb-plugin-canvas-webrtc-record" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/rrweb-plugin-canvas-webrtc-replay" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/rrweb-plugin-console-record" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/rrweb-plugin-console-replay" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/rrweb-plugin-sequential-id-record" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/rrweb-plugin-sequential-id-replay" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/utils" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@mayberryzane mayberryzane changed the title Zane/related resources [HIG-4596] related resources from metric dashboards Jul 22, 2024
@linear
Copy link

linear bot commented Jul 22, 2024

HIG-4596 Link from dashboard back to product

@mayberryzane mayberryzane requested review from a team and SpennyNDaJets and removed request for a team July 22, 2024 04:20
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 22, 2024
View reviewed changes
backend/store/error_groups_test.go
store.DB.Create(&errorObject)
ids := []int64{int64(errorObject.ID)}
results, err := store.ListErrorObjects(context.TODO(), errorGroup, ids, 1)
results, err := store.ListErrorObjects(context.TODO(), ids, 1)

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality

Suspicious comment
backend/store/error_groups_test.go
store.DB.Create(&errorObject)
ids := []int64{int64(errorObject.ID)}
results, err := store.ListErrorObjects(context.TODO(), errorGroup, ids, 71)
results, err := store.ListErrorObjects(context.TODO(), ids, 71)

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality

Suspicious comment
backend/store/error_groups_test.go

// No error objects
results, err := store.ListErrorObjects(context.TODO(), errorGroup, make([]int64, 0), 0)
results, err := store.ListErrorObjects(context.TODO(), make([]int64, 0), 0)

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality

Suspicious comment
SpennyNDaJets
SpennyNDaJets approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@SpennyNDaJets SpennyNDaJets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mayberryzane mayberryzane merged commit 1e19eb5 into main Jul 28, 2024
@mayberryzane mayberryzane deleted the zane/related_resources branch July 28, 2024 20:25
@mayberryzane
Copy link
Contributor Author

mayberryzane commented Jul 28, 2024

monorepo step failing - continuing because there are no new npm versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SpennyNDaJets SpennyNDaJets SpennyNDaJets approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mayberryzane @SpennyNDaJets