fix highlight.run getSessionUrl only returning session ID #9041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
2717bc2 to
9f0234b
Compare
9f0234b to
ca60621
Compare
Comment on lines
+79
to
+80
| const { url, urlWithTimestamp } = await win.eval( | ||
| `H.getSessionDetails()`, |
Check notice
Code scanning / devskim
If untrusted data (data from HTTP requests, user submitted files, etc.) is included in an eval statement it can allow an attacker to inject their own code.
| win.eval(`fetch('${baseUrl}/index.html', {method: 'POST'})`) | ||
| win.eval(`H.track('MyTrackEvent', {'foo': 'bar'})`) | ||
|
|
||
| const result = await win.eval(`H.getSessionURL()`) |
Check notice
Code scanning / devskim
If untrusted data (data from HTTP requests, user submitted files, etc.) is included in an eval statement it can allow an attacker to inject their own code.
ccschmitz
approved these changes
Aug 2, 2024
Contributor
ccschmitz
left a comment
There was a problem hiding this comment.
Nice! Looks good to me, but did not click test. Let me know if you want me to pull down and click test, but looks like the new test covers the change pretty well!
54be34f to
9cdae87
Compare
Releases: highlight.run@9.1.3 @highlight-run/next@7.5.14 @highlight-run/remix@2.0.45 [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
getSessionURLto return the full session urlgetSessionDetailsto return the URL with timestamp without blocking for the client.How did you test this change?
new cypress test additions
Are there any deployment considerations?
changeset
Does this work require review from our design team?
no