Skip to content

fix log template interpolation in .NET SDKs #9473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Vadman97 merged 10 commits into from
Oct 17, 2024
Merged

fix log template interpolation in .NET SDKs #9473

Vadman97 merged 10 commits into from
Oct 17, 2024

Conversation

@Vadman97
Copy link
Member

@Vadman97 Vadman97 commented Oct 17, 2024 •
edited
Loading

Summary

Logs with a template string would be recording a log message without interpolating variables into the message body.
Update the Opentelemetry configuration to ensure OTEL interpolates the template string.

How did you test this change?

e2e dotnet app

before
Screenshot from 2024-10-17 09-28-05

after
Screenshot from 2024-10-17 10-03-24

Are there any deployment considerations?

new .net and .net4 package versions

Does this work require review from our design team?

no

@Vadman97 Vadman97 requested review from a team and ccschmitz and removed request for a team October 17, 2024 14:28
@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 25c0d83

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR 
Some errors occurred when validating the changesets config:
The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/all" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/record" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/replay" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/packer" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/rrweb-plugin-canvas-webrtc-record" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/rrweb-plugin-canvas-webrtc-replay" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/rrweb-plugin-console-record" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/rrweb-plugin-console-replay" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/rrweb-plugin-sequential-id-record" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/rrweb-plugin-sequential-id-replay" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/utils" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@Vadman97 Vadman97 requested review from mayberryzane and removed request for ccschmitz October 17, 2024 22:05
@Vadman97 Vadman97 force-pushed the vadim/dotnet-sdk-logs-interpolation branch from 13fdfa1 to 25c0d83 Compare October 17, 2024 22:14
@Vadman97 Vadman97 enabled auto-merge (squash) October 17, 2024 22:14
@Vadman97 Vadman97 merged commit 0ff3b93 into main Oct 17, 2024
@Vadman97 Vadman97 deleted the vadim/dotnet-sdk-logs-interpolation branch October 17, 2024 23:10
giraffekey pushed a commit to giraffekey/highlight that referenced this pull request Nov 21, 2024
@Vadman97 @giraffekey
fix log template interpolation in .NET SDKs (highlight#9473)
60ce8a1 
## Summary

Logs with a template string would be recording a log message without
interpolating variables into the message body.
Update the Opentelemetry configuration to ensure OTEL interpolates the
template string.

## How did you test this change?

e2e dotnet app

before
![Screenshot from 2024-10-17
09-28-05](https://github.com/user-attachments/assets/e2dd3d55-397b-4fb9-94f9-10c357819318)

after
![Screenshot from 2024-10-17
10-03-24](https://github.com/user-attachments/assets/476fdefa-eb32-49eb-b7e6-e745108a3882)

## Are there any deployment considerations?

new .net and .net4 package versions

## Does this work require review from our design team?

no
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mayberryzane mayberryzane mayberryzane approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Vadman97 @mayberryzane