Skip to content

fix more alert infinite loops #9947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mayberryzane merged 1 commit into from
Feb 11, 2025
Merged

fix more alert infinite loops #9947

mayberryzane merged 1 commit into from
Feb 11, 2025

Conversation

@mayberryzane
Copy link
Contributor

@mayberryzane mayberryzane commented Feb 7, 2025

Summary

  • use string comparisons in the dependency array for retrieving graph data to prevent infinite looping

How did you test this change?

  • clicktested locally, changed every field in the alert page to ensure no looping

Are there any deployment considerations?

  • no

Does this work require review from our design team?

  • no

@mayberryzane mayberryzane requested review from a team and Vadman97 and removed request for a team February 7, 2025 22:16
@mayberryzane mayberryzane merged commit 79c70f9 into main Feb 11, 2025
28 checks passed
@mayberryzane mayberryzane deleted the zane/fix_loops branch February 11, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Vadman97 Vadman97 Vadman97 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mayberryzane @Vadman97