Skip to content

Add RGB to OD filter#290

Merged
alessiamarcolini merged 1 commit into
masterfrom
rgb_to_od_filter
Jul 21, 2021
Merged

Add RGB to OD filter#290
alessiamarcolini merged 1 commit into
masterfrom
rgb_to_od_filter

Conversation

@alessiamarcolini

@alessiamarcolini alessiamarcolini commented Jul 19, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Add RGB to OD filter

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@alessiamarcolini alessiamarcolini linked an issue Jul 19, 2021 that may be closed by this pull request
RGB to OD filter #289
Closed
@alessiamarcolini alessiamarcolini added this to the 0.2.7 milestone Jul 19, 2021
nicolebussola
nicolebussola approved these changes Jul 19, 2021
View reviewed changes

@nicolebussola nicolebussola left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ernestoarbitrio
ernestoarbitrio requested changes Jul 19, 2021
View reviewed changes

@ernestoarbitrio ernestoarbitrio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 code style tweaks

Comment thread src/histolab/filters/image_filters_functional.py Outdated
Comment thread tests/unit/filters/test_image_filters.py Outdated
@codecov

codecov Bot commented Jul 20, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #290 (0906695) into master (cd32904) will decrease coverage by 0.64%.
The diff coverage is 100.00%.

❗ Current head 0906695 differs from pull request most recent head 71b95af. Consider uploading reports for the commit 71b95af to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##            master     #290      +/-   ##
===========================================
- Coverage   100.00%   99.36%   -0.65%     
===========================================
  Files           17       17              
  Lines         1237     1250      +13     
  Branches       117      118       +1     
===========================================
+ Hits          1237     1242       +5     
- Misses           0        8       +8
Impacted Files Coverage Δ
src/histolab/filters/image_filters.py 98.99% <100.00%> (-1.01%) ⬇️
src/histolab/filters/image_filters_functional.py 100.00% <100.00%> (ø)
src/histolab/scorer.py 92.59% <0.00%> (-7.41%) ⬇️
src/histolab/filters/morphological_filters.py 97.26% <0.00%> (-2.74%) ⬇️
src/histolab/tiler.py 99.19% <0.00%> (-0.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd32904...71b95af. Read the comment docs.

@alessiamarcolini alessiamarcolini force-pushed the rgb_to_od_filter branch 4 times, most recently from ac186f0 to 882792b Compare July 21, 2021 13:36
@alessiamarcolini alessiamarcolini merged commit 5951a6b into master Jul 21, 2021
@alessiamarcolini alessiamarcolini deleted the rgb_to_od_filter branch July 21, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ernestoarbitrio ernestoarbitrio ernestoarbitrio approved these changes

@nicolebussola nicolebussola nicolebussola approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.3.0

Development

Successfully merging this pull request may close these issues.

RGB to OD filter

3 participants

@alessiamarcolini @ernestoarbitrio @nicolebussola