add conversion level - magnification factor, when possible#319
Merged
Conversation
ernestoarbitrio
requested changes
Sep 20, 2021
Codecov Report
@@ Coverage Diff @@
## master #319 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 1294 1307 +13
Branches 124 127 +3
=========================================
+ Hits 1294 1307 +13
Continue to review full report at Codecov.
|
alessiamarcolini
requested changes
Sep 20, 2021
alessiamarcolini
requested changes
Sep 20, 2021
alessiamarcolini
left a comment
Collaborator
There was a problem hiding this comment.
Now the tests that are included are ok.
However, since the integration test it_knows_its_magnification_factors is basically run only on CI, I would add:
- a test case for that method to use the local
cmu-1-small-region.svs - two unit tests using a fake svs and mocking
propertiesproperty to include or not"openslide.objective-power"and"f"openslide.level[{level}].downsample"to better control the flow. Let's try to have 100% coverage on the new modifications without the help of the integration tests
alessiamarcolini
requested changes
Sep 21, 2021
f056e68 to
9a2c72d
Compare
5e04da8 to
5056046
Compare
ernestoarbitrio
approved these changes
Sep 22, 2021
ernestoarbitrio
left a comment
Member
There was a problem hiding this comment.
LGTM but let's see if you can address the minor comment I just wrote
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address Issue #294