Skip to content

Conversion from RGB to HSV preserves HSV color space range#337

Merged
alessiamarcolini merged 4 commits into
masterfrom
fix-hsv-filter
Nov 2, 2021
Merged

Conversion from RGB to HSV preserves HSV color space range#337
alessiamarcolini merged 4 commits into
masterfrom
fix-hsv-filter

Conversation

@alessiamarcolini

@alessiamarcolini alessiamarcolini commented Oct 29, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Per title

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

  • Fixes:

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@alessiamarcolini alessiamarcolini added this to the 0.2.7 milestone Oct 29, 2021
@alessiamarcolini alessiamarcolini mentioned this pull request Nov 1, 2021
Closed
@alessiamarcolini

alessiamarcolini commented Nov 1, 2021

Copy link
Copy Markdown
Collaborator Author

#339 to be merged first

@codecov

codecov Bot commented Nov 1, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #337 (e989a55) into master (f3dbedf) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #337   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         1307      1305    -2     
  Branches       128       128           
=========================================
- Hits          1307      1305    -2
Impacted Files Coverage Δ
histolab/filters/image_filters.py 100.00% <100.00%> (ø)
histolab/filters/image_filters_functional.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3dbedf...e989a55. Read the comment docs.

@alessiamarcolini alessiamarcolini merged commit c4f75d3 into master Nov 2, 2021
@alessiamarcolini alessiamarcolini deleted the fix-hsv-filter branch November 2, 2021 11:37
@alessiamarcolini alessiamarcolini linked an issue Nov 2, 2021 that may be closed by this pull request
Conversion from RGB to HED must preserve HED color space range #326
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ernestoarbitrio ernestoarbitrio ernestoarbitrio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.3.0

Development

Successfully merging this pull request may close these issues.

Conversion from RGB to HED must preserve HED color space range

2 participants

@alessiamarcolini @ernestoarbitrio