Skip to content

Add cache for WSI files#358

Merged
alessiamarcolini merged 3 commits into
histolab:masterfrom
patrick91:feature/cache-wsis
Nov 26, 2021
Merged

Add cache for WSI files#358
alessiamarcolini merged 3 commits into
histolab:masterfrom
patrick91:feature/cache-wsis

Conversation

@patrick91

@patrick91 patrick91 commented Nov 25, 2021

Copy link
Copy Markdown
Collaborator

This PR adds a cache for WSI files in order to prevent downloading them all the time from the external servers.

An alternative could be to use Git LFS to store those files on the repo itself :)

@patrick91 patrick91 marked this pull request as ready for review November 25, 2021 20:31
@codecov

codecov Bot commented Nov 25, 2021

Copy link
Copy Markdown

Codecov Report

Merging #358 (41f3c8a) into master (348f945) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #358   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         1408      1408           
  Branches       152       152           
=========================================
  Hits          1408      1408           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 348f945...41f3c8a. Read the comment docs.

@alessiamarcolini alessiamarcolini left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing 🙌🏼🥰

@patrick91 @ernestoarbitrio are we ready to merge?

@ernestoarbitrio

Copy link
Copy Markdown
Member

We are

@alessiamarcolini alessiamarcolini merged commit 0c49ba5 into histolab:master Nov 26, 2021
@alessiamarcolini alessiamarcolini added this to the 0.4.1 milestone Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants