Hi @nipeone, congrats on your first contribution to Histolab 🎉

but if i create new PR,need i create unit test about this issue?

For this issue, an integration test would be better. Please note that we are testing the Tilers using the locate_tiles method (better to visualize, easier to test) https://github.com/histolab/histolab/blob/master/tests/integration/test_tiler.py#L331
So you could write a new test using only 1 or 2 fixtures following the test structure of it_locates_tiles_on_the_slide and changing the value of the parameter pixel_overlap.

Of course, if you need guidance on this we are here ❤️

Alessia

so sad,it's a little hard to me add integration test in test_tiler.py, i have tried.

Hey @nipeone, I added the missing integration test, no problem.

@ernestoarbitrio however, this PR will fail again for the same reason as #371

Hey @nipeone, I added the missing integration test, no problem.

@ernestoarbitrio however, this PR will fail again for the same reason as #371

now it should be ok

Codecov Report

Merging #372 (360bdb2) into master (b71a1c6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #372   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         1411      1411           
  Branches       218       218           
=========================================
  Hits          1411      1411           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa32c58...360bdb2. Read the comment docs.

Hey @nipeone, I added the missing integration test, no problem.

@ernestoarbitrio however, this PR will fail again for the same reason as #371
that's great!!!